Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delimiter for list of values #3686

Merged
merged 4 commits into from
Apr 10, 2023
Merged

Add delimiter for list of values #3686

merged 4 commits into from
Apr 10, 2023

Conversation

sayuree
Copy link
Contributor

@sayuree sayuree commented Mar 24, 2023 •
edited by joshuarrrr
Loading

Description

[Added delimiter for values in Add filter]

Issues Resolved

partially opensearch-project/oui#661

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@sayuree sayuree requested a review from a team as a code owner March 24, 2023 17:16
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2023 •
edited
Loading

Codecov Report

Merging #3686 (9232833) into main (44e2e34) will increase coverage by 0.04%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3686      +/-   ##
==========================================
+ Coverage   66.38%   66.43%   +0.04%     
==========================================
  Files        3210     3210              
  Lines       61676    61676              
  Branches     9522     9522              
==========================================
+ Hits        40942    40972      +30     
+ Misses      18448    18422      -26     
+ Partials     2286     2282       -4
Flag Coverage Δ
Linux 66.37% <ø> (?)
Windows 66.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr joshuarrrr added the OSCI Open Source Contributor Initiative label Mar 27, 2023
@sayuree
Add delimiter
d738b79 
Signed-off-by: sabina.zaripova <[email protected]>
@joshuarrrr
Copy link
Member

@sayuree For this PR, it would be helpful to add a screencast or multiple screenshots of what it's like to use the new field to add multiple filters.

@ashwin-pc ashwin-pc added the needs more info Requires more information from poster label Apr 3, 2023
@joshuarrrr joshuarrrr self-assigned this Apr 4, 2023
@joshuarrrr joshuarrrr mentioned this pull request Apr 4, 2023
Open
@joshuarrrr
Copy link
Member

This is not a complete fix for the issue (see opensearch-project/oui#661). But it is a step in the right direction.

joshuarrrr
joshuarrrr reviewed Apr 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@joshuarrrr
Copy link
Member

@sayuree All tests pass, and the change looks good. Just a couple small changes requested for the CHANGELOG, then we can approve.

@sayuree
Edit CHANGELOG.md
d7ddf6b 
Signed-off-by: sabina.zaripova <[email protected]>
@joshuarrrr
Copy link
Member

All tests passed

joshuarrrr
joshuarrrr approved these changes Apr 10, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@joshuarrrr joshuarrrr added v2.7.0 backport 2.x and removed needs more info Requires more information from poster labels Apr 10, 2023
@joshuarrrr joshuarrrr merged commit be47d9a into opensearch-project:main Apr 10, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 10, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 10, 2023
@github-actions
Add delimiter for list of values (#3686)
7eab15a 
* Add delimiter
* Edit CHANGELOG.md

Signed-off-by: sabina.zaripova <[email protected]>

---------

Signed-off-by: sabina.zaripova <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit be47d9a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
manasvinibs pushed a commit that referenced this pull request Apr 11, 2023
@opensearch-trigger-bot @github-actions @joshuarrrr
[Backport 2.x] Add delimiter for list of values (#3818)
8693f5d 
* Add delimiter for list of values (#3686)

* Add delimiter
* Edit CHANGELOG.md

Signed-off-by: sabina.zaripova <[email protected]>

---------

Signed-off-by: sabina.zaripova <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit be47d9a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

* add changelog

Signed-off-by: Josh Romero <[email protected]>

---------

Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <[email protected]>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@sayuree @joshuarrrr @sikhote
Add delimiter for list of values (opensearch-project#3686)
8522274 
* Add delimiter
* Edit CHANGELOG.md

Signed-off-by: sabina.zaripova <[email protected]>

---------

Signed-off-by: sabina.zaripova <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuarrrr joshuarrrr joshuarrrr approved these changes

@manasvinibs manasvinibs manasvinibs approved these changes

Assignees

@joshuarrrr joshuarrrr

Labels
backport 2.x OSCI Open Source Contributor Initiative v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sayuree @codecov-commenter @joshuarrrr @manasvinibs @ashwin-pc